RFC: Notification system for cli updates #146
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Notification system for cli updates | ||
|
|
||
| ## Summary | ||
|
|
||
| A new notification system to warn users about new versions of the **npm cli**. | ||
|
|
||
| ## Motivation | ||
|
|
||
| - Remove an extra http request from the cli | ||
| - Remove dependency on `update-notifier` | ||
| - Original discussion: https://github.com/npm/rfcs/discussions/118 | ||
|
|
||
| ## Rationale and Alternatives | ||
|
|
||
| - Do nothing, keep the same system in place | ||
| - More alternatives? | ||
|
|
||
| ## Implementation | ||
|
|
||
| - Set a `user-agent` header in the requests from the **npm cli** | ||
| - Add a check on the registry that notifies user if a greater version of the cli is available | ||
|
There was a problem hiding this comment. this needs to take into account the node version; there's very complex logic (https://github.com/nvm-sh/nvm/blob/master/nvm.sh#L150-L269) for figuring out which npm version works on which node version, and it would be pretty bad if npm suggesting updating on a node version where the act of updating completely hosed the entire node install by breaking npm. |
||
| - Add a new header in the registry response that alerts for a new version of the cli | ||
| - Also allow customization so that other registry clients can implement/benefit from the same system | ||
|
|
||
| ## Prior Art | ||
|
|
||
| - https://www.npmjs.com/package/update-notifier | ||
|
|
||
| ## Unresolved Questions and Bikeshedding | ||
|
|
||
| TBD | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this makes sense. It is just one request per week. During an installation there are hundreds of requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my guess is that when this was brought up it was with regards to commands that should not necessarily hit the registry, such as
npm lsbut i do agree with your point, it might be silly and not worth having this listed in the RFC after allThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth it to keep it if reducing HTTP calls where they may not be necessary is a goal of the project (I think that's a fair and valid goal).