Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up requires #371

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: clean up requires #371

merged 1 commit into from
May 7, 2024

Conversation

wraithgar
Copy link
Member

Missed a totally private symbol, moved to private method
added node: prefix to requires
cleaned up a few tests that needed it to work w/ the new requires

Missed a totally private symbol, moved to private method
added `node:` prefix to requires
cleaned up a few tests that needed it to work w/ the new requires
@wraithgar wraithgar requested a review from a team as a code owner May 7, 2024 21:25
Copy link
Contributor

@lukekarrys lukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@wraithgar wraithgar merged commit 79441a5 into main May 7, 2024
17 checks passed
@wraithgar wraithgar deleted the gar/cleanup branch May 7, 2024 21:42
@github-actions github-actions bot mentioned this pull request May 7, 2024
lukekarrys pushed a commit that referenced this pull request May 8, 2024
🤖 I have created a release *beep* *boop*
---


## [18.0.6](v18.0.5...v18.0.6)
(2024-05-07)

### Bug Fixes

*
[`79441a5`](79441a5)
[#371](#371) clean up requires (#371)
(@wraithgar)
*
[`b19aacb`](b19aacb)
[#369](#369) isolate full and corgi
packuments in packumentCache (#369) (@wraithgar)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants