fix: wait for size event from body for contentLength #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
May 6, 2024
| @@ -96,7 +98,11 @@ class RegistryFetcher extends Fetcher { | |||
| integrity: null, | |||
| }) | |||
| const packument = await res.json() | |||
| packument._contentLength = +res.headers.get('content-length') | |||
| let contentLength = res.headers.get('content-length') ?? null | |||
There was a problem hiding this comment.
Is this ?? effectively the same test as isStream? Do we really need them both?
wraithgar
previously approved these changes
May 6, 2024
lukekarrys
added a commit
that referenced
this pull request
May 6, 2024
The opposite of #366. This is not a change in behavior but makes it clear that we don't expect _contentLength to be set when the request is coming directly from the registry when there is no cache.
lukekarrys
added a commit
that referenced
this pull request
May 6, 2024
The opposite of #366. This is not a change in behavior but makes it clear that we don't expect _contentLength to be set when the request is coming directly from the registry when there is no cache.
|
Closing in favor of #368. We don't want to wait for the entire stream to be decompressed and get the size event before moving on here. We could potentially Instead #368 makes it clear we won't get a contentLength from the registry, so we won't cache those in-memory since we can't be sure of their size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the
Accept-Encodingrequest header is set togzip,deflatewhich makes it so we don't get back aContent-Lengthresponse header from the registry. Butnpm-registry-fetchsets up asizeevent on the response body that we can wait for before continuing if we don't get aContent-Lengthheader.This fixes the content length issue in #7463 for me when testing locally, but I need to run some more CLI tests with this linked to see if there are any adverse effects.