feat: add bun.lockb to ignorelist
#168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason that didn't get implemented is likely due more to the fact that it was a breaking change that got lost in the npm@7 timeline than anything else. A change like this would bubble up as a breaking change all the way up to npm itself, and would need to be coordinated with the next semver major of npm. |
|
I added #48 to the v10 roadmap to see if this is something we want to finally do |
|
Are people using bun with packages all that much? I thought it was for apps. |
|
changing the scope of ignored files was moved out of scope of npm 10 so that it could land eventually in node 18's main branch (which it has now!). This will have to wait till npm 11. |
|
I suggest adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: this adds
bun.lockbto the strict ignorelist