Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo glibcRuntimeVersion glibcVersionRuntime #57

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

snyamathi
Copy link
Contributor

@snyamathi snyamathi commented Apr 11, 2023

cc @nlf @wraithgar I think this was a typo introduced in #54 and the correct header is glibcVersionRuntime as seen here: https://github.com/search?q=org%3Anodejs+glibcVersionRuntime&type=code

bash-4.2# npm i npm-install-checks
+ [email protected]
added 4 packages from 3 contributors and audited 4 packages in 0.83s
found 0 vulnerabilities

bash-4.2# node -e "require('npm-install-checks').checkPlatform({libc:'glibc'})"
/foo/node_modules/npm-install-checks/lib/index.js:53
    throw Object.assign(new Error('Unsupported platform'), {
    ^

Error: Unsupported platform
    at Object.checkPlatform (/foo/node_modules/npm-install-checks/lib/index.js:53:25)
    at [eval]:1:31
    at Script.runInThisContext (node:vm:129:12)
    at Object.runInThisContext (node:vm:313:38)
    at node:internal/process/execution:79:19
    at [eval]-wrapper:6:22
    at evalScript (node:internal/process/execution:78:60)
    at node:internal/main/eval_string:27:3 {
  pkgid: undefined,
  current: { os: 'linux', cpu: 'x64', libc: null },
  required: { os: undefined, cpu: undefined, libc: 'glibc' },
  code: 'EBADPLATFORM'
}

bash-4.2# patch -u node_modules/npm-install-checks/lib/index.js pr57.patch 
patching file node_modules/npm-install-checks/lib/index.js

bash-4.2# node -e "require('npm-install-checks').checkPlatform({libc:'glibc'})"
bash-4.2# echo $?
0

@snyamathi snyamathi requested a review from a team as a code owner April 11, 2023 22:15
@snyamathi snyamathi requested review from wraithgar and removed request for a team April 11, 2023 22:15
Copy link

@carriemorrison carriemorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants