deps: use resolve.isCore instead of is-builtin-module for better …

…data and better node compat (#99)

PR-URL: #99
Credit: @ljharb
Reviewed-By: @aeschright

lib/fixer.js

@@ -1,7 +1,7 @@
 var semver = require("semver")
 var validateLicense = require('validate-npm-package-license');
 var hostedGitInfo = require("hosted-git-info")
-var isBuiltinModule = require("is-builtin-module")
+var isBuiltinModule = require("resolve").isCore
 var depTypes = ["dependencies","devDependencies","optionalDependencies"]
 var extractDescription = require("./extract_description")
 var url = require("url")

package.json

@@ -14,7 +14,7 @@
   },
   "dependencies": {
     "hosted-git-info": "^2.1.4",
-    "is-builtin-module": "^1.0.0",
+    "resolve": "^1.10.0",
     "semver": "2 || 3 || 4 || 5",
     "validate-npm-package-license": "^3.0.1"
   },

test/normalize.js

@@ -62,22 +62,26 @@ tap.test("core module name", function(t) {
   function warn(m) {
     warnings.push(m)
   }
+  var coreModules = ["http", "_stream_writable"]
   var a
-  normalize(a={
-    name: "http",
-    readme: "read yourself how about",
-    homepage: 123,
-    bugs: "what is this i don't even",
-    repository: "Hello."
-  }, warn)
+  var expect = []
+  for (var i = 0; i < coreModules.length; ++i) {
+    normalize(a={
+      name: coreModules[i],
+      readme: "read yourself how about",
+      homepage: 123,
+      bugs: "what is this i don't even",
+      repository: "Hello."
+    }, warn)
 
-  var expect = [
-      safeFormat(warningMessages.conflictingName, 'http'),
+    expect = expect.concat([
+      safeFormat(warningMessages.conflictingName, coreModules[i]),
       warningMessages.nonEmailUrlBugsString,
       warningMessages.emptyNormalizedBugs,
       warningMessages.nonUrlHomepage,
       warningMessages.missingLicense
-      ]
+    ])
+  }
   t.same(warnings, expect)
   t.end()
 })