Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid re-instantiating SemVer during diff compare #547

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix: avoid re-instantiating SemVer during diff compare #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions functions/diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
const parse = require('./parse')
const eq = require('./eq')

const diff = (version1, version2) => {
const v1 = parse(version1)
const v2 = parse(version2)
if (eq(v1, v2)) {
if (v1.compare(v2) === 0) {
return null
} else {
const hasPre = v1.prerelease.length || v2.prerelease.length
Expand Down