Exclude prereleases from range maximums #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In semver v4, the ranges were simplified in 2331a9e "to remove -0 everywhere". This had the unintended side effect of including the endpoint version's prerelease versions in the resulting range, as lt('1.0.0-0', '1.0.0') === true. Tests are updated, adding -0 to the maximal endpoints. One test is moved from range-include to range-exclude, comparing 2.0.0-rc1 against ^1.0.0 Fixes npm#223 Fixes npm#254
|
@isaacs why was this PR and all related issues closed without merging and with no rationale listed? Is this intended behavior? It seems surprising and unintuitive. |
|
@elashpear this PR was merged via landing a squashed commit - see the hash in the closing message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In semver v4, the ranges were simplified in 2331a9e "to remove -0 everywhere". This had the unintended side effect of including the endpoint version's prerelease versions in the resulting range, as
semver.lt('2.0.0-0', '2.0.0') === true.This bug is apparent in intersection tests:
To fix this, the
Rangeclass is updated to always include-0in the<Comparator when generating one from expressions like1.x,1.0 - 1.5,~1.2.3, or^1.2.Tests are updated, moving one test from range-include to range-exclude, comparing
2.0.0-rc1against^1.0.0whenincludePrereleaseis trueFixes #223
Fixes #254