This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
make collect() respect stream pause/resume state #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a55ae72. Unnecessary when collect() handles pause/resume state properly, this compounds the issue and adds unnecessary entries to the list.
Addressing npm/npm#5082 Without watching if a stream is already paused before calling pause(), collect() can conflict with other users of the stream who may be managing state, resulting in a premature collect(). This manifests in the fstream-npm and node-tar combination where fstream-npm manages state in readBundledLinks() at the same time collect() is processing the stream. collect() ends up running before fstream-npm has properly set up the _correct_ list of entries according to the ignore rules. When collect() gets to run before this is complete, fstream starts performing _read() operations on a non-filtered list, keeping track of entry index, then after it starts, fstream-npm inserts a new list of entries and the entry index is incorrect and can skip files.
|
1 line of code. GG good sir! |
othiym23
pushed a commit
that referenced
this pull request
Jun 17, 2016
othiym23
pushed a commit
that referenced
this pull request
Jun 17, 2016
Without watching if a stream is already paused before calling pause(), collect() can conflict with other users of the stream who may be managing state, resulting in a premature collect(). This manifests in the fstream-npm and node-tar combination where fstream-npm manages state in readBundledLinks() at the same time collect() is processing the stream. collect() ends up running before fstream-npm has properly set up the _correct_ list of entries according to the ignore rules. When collect() gets to run before this is complete, fstream starts performing _read() operations on a non-filtered list, keeping track of entry index, then after it starts, fstream-npm inserts a new list of entries and the entry index is incorrect and can skip files. Fixes: npm/npm#5082 Credit: @rvagg Reviewed-By: @othiym23 PR-URL: #53
|
Landed as a67b90b and 24c2ad5, released as |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collect()that makes it properly respect state so the ignore list gets to be properly built before fstream starts reading entries.Explained in commit message:
Without watching if a stream is already paused before calling pause(),
collect() can conflict with other users of the stream who may be
managing state, resulting in a premature collect().
This manifests in the fstream-npm and node-tar combination where
fstream-npm manages state in readBundledLinks() at the same time
collect() is processing the stream. collect() ends up running before
fstream-npm has properly set up the correct list of entries according
to the ignore rules. When collect() gets to run before this is complete,
fstream starts performing _read() operations on a non-filtered list,
keeping track of entry index, then after it starts, fstream-npm inserts
a new list of entries and the entry index is incorrect and can skip
files.