Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port @npmcli/move-file #63

Merged
merged 3 commits into from
Nov 3, 2022
Merged

feat: port @npmcli/move-file #63

merged 3 commits into from
Nov 3, 2022

Conversation

lukekarrys
Copy link
Contributor

Closes #56

@lukekarrys lukekarrys requested a review from a team as a code owner November 3, 2022 17:21
@wraithgar
Copy link
Member

We don't appear to use the sync methods. arborist and cacache are the two places I found using this, neither call moveFile.sync.

@lukekarrys
Copy link
Contributor Author

Rebased and removed the sync method.

@lukekarrys lukekarrys merged commit ecbb150 into main Nov 3, 2022
@lukekarrys lukekarrys deleted the lk/move-file branch November 3, 2022 20:22
@github-actions github-actions bot mentioned this pull request Nov 3, 2022
Merged
@lisagorewitdecker lisagorewitdecker mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement move-file
2 participants
@lukekarrys @wraithgar