Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci summary: change console.error for console.log #79

Merged
merged 1 commit into from
Nov 26, 2018
Merged

ci summary: change console.error for console.log #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ci.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function ci (args, cb) {
.then(
(details) => {
npmlog.disableProgress()
console.error(`added ${details.pkgCount} packages in ${
console.log(`added ${details.pkgCount} packages in ${
details.runTime / 1000
}s`)
}
Expand Down
10 changes: 4 additions & 6 deletions test/tap/ci.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ test('basic installation', (t) => {
const stdout = ret[1]
const stderr = ret[2]
t.equal(code, 0, 'command completed without error')
t.equal(stdout.trim(), '', 'no output on stdout')
t.equal(stderr.trim(), '', 'no output on stderr')
t.match(
stderr.trim(),
stdout.trim(),
/^added 6 packages in \d+(?:\.\d+)?s$/,
'no warnings on stderr, and final output has right number of packages'
)
Expand Down Expand Up @@ -150,9 +150,9 @@ test('supports npm-shrinkwrap.json as well', (t) => {
const stdout = ret[1]
const stderr = ret[2]
t.equal(code, 0, 'command completed without error')
t.equal(stdout.trim(), '', 'no output on stdout')
t.equal(stderr.trim(), '', 'no output on stderr')
t.match(
stderr.trim(),
stdout.trim(),
/^added 6 packages in \d+(?:\.\d+)?s$/,
'no warnings on stderr, and final output has right number of packages'
)
Expand Down Expand Up @@ -197,10 +197,8 @@ test('removes existing node_modules/ before installing', (t) => {
], EXEC_OPTS))
.then((ret) => {
const code = ret[0]
const stdout = ret[1]
const stderr = ret[2]
t.equal(code, 0, 'command completed without error')
t.equal(stdout.trim(), '', 'no output on stdout')
t.match(
stderr.trim(),
/^npm.*WARN.*removing existing node_modules/,
Expand Down