Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tolerate null bugs URLs #6798

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: tolerate null bugs URLs #6798

merged 1 commit into from
Sep 13, 2023

Commits on Sep 12, 2023

  1. fix: tolerate null bugs URLs 

    Currently, if the bugs URL returned from `package.json`, which is
processed through
[hosted-git-info](https://github.com/npm/hosted-git-info), is falsy, an
error is thrown. However, hosted-git-info may well return a falsy bugs
URL. This can happen when there is no bugs URL in the repo, but
hosted-git-info tries to infer one, but one cannot be inferred, for
example if the repository URL is a SourceHut URL. This is described
here: npm/hosted-git-info#213

For this reason, we should tolerate falsy URLs and fall back to whatever
is defined in `bugs.js`, in this case being sent to
https://www.npmjs.com/package/<packageName>.
    @vladh
    vladh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fac8fff View commit details
    Browse the repository at this point in the history