Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update description for publish --provenance flag #6381

Merged
merged 2 commits into from
Apr 19, 2023
Merged

docs: Update description for publish --provenance flag #6381

merged 2 commits into from
Apr 19, 2023

Conversation

feelepxyz
Copy link
Contributor

@feelepxyz feelepxyz requested a review from a team as a code owner April 19, 2023 14:46
@feelepxyz feelepxyz requested review from wraithgar and removed request for a team April 19, 2023 14:46
@wraithgar wraithgar changed the title Update description for publish --provenance flag docs: Update description for publish --provenance flag Apr 19, 2023
@@ -1624,7 +1624,7 @@ define('provenance', {
default: false,
type: Boolean,
description: `
Indicates that a provenance statement should be generated.
When you publish from a supported cloud CI/CD system, this will publicly establish where the package was built and published from.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you publish from a supported cloud CI/CD system, this will publicly establish where the package was built and published from.
When you publish from a supported cloud CI/CD system, this will publicly
establish where the package was built and published from.

@wraithgar
Copy link
Member

npm run snap will update the test snapshots that look at help and docs output.

Signed-off-by: Philip Harrison <[email protected]>
@wraithgar wraithgar merged commit 31214a6 into npm:latest Apr 19, 2023
@github-actions github-actions bot mentioned this pull request Apr 19, 2023
@@ -1624,7 +1624,8 @@ define('provenance', {
default: false,
type: Boolean,
description: `
Indicates that a provenance statement should be generated.
When publishing from a supported cloud CI/CD system, the package will be
publicly linked to where it was built and published from.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we don't want to end sentences with a preposition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants