-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert install-links
default back to false
#6142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this new default was unintentionally breaking so we are reverting it as a bug fix, see nodejs/node#46542
no statistically significant performance changes detected timing results
|
MylesBorins
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lukekarrys
approved these changes
Feb 7, 2023
Merged
jhheider
added a commit
to pkgxdev/pantry.core
that referenced
this pull request
Feb 7, 2023
jhheider
added a commit
to pkgxdev/pantry.core
that referenced
this pull request
Feb 7, 2023
2 tasks
2 tasks
ascott18
added a commit
to IntelliTect/Coalesce
that referenced
this pull request
Feb 17, 2023
This was referenced Mar 28, 2023
This was referenced Aug 21, 2023
max-sixty
added a commit
to max-sixty/prql
that referenced
this pull request
Sep 2, 2023
This is no longer needed; the npm change was reverted in `9.4.0`: npm/cli#6142
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this new default was unintentionally breaking so we are reverting it as a bug fix, see nodejs/node#46542
note that this is technically a breaking change. however, since the new default was not delivered appropriately we are reverting this in a patch release as we consider it a bug fix.
if you have already updated to npm@9 and your project includes dependencies using the
file:
protocol, then it is possible that this change will cause thenpm ci
command to fail informing you that your package.json and package-lock.json are out of sync. if this happens, re-runningnpm install
will correct the lockfile and cause thenpm ci
command to work again as expected.