Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecated set-script, birthday, --global, and --local #4879

Merged
merged 1 commit into from
May 18, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented May 10, 2022

@fritzy fritzy changed the title feat: deprecated commands set-script and birthday feat: deprecated set-script, birthday, --global, and --local May 10, 2022
@fritzy fritzy marked this pull request as ready for review May 10, 2022 17:42
@fritzy fritzy requested a review from a team as a code owner May 10, 2022 17:42
@fritzy fritzy force-pushed the fritzy/deprecations branch from f5adb51 to 08e0689 Compare May 10, 2022 17:55
@fritzy
Copy link
Contributor Author

fritzy commented May 10, 2022

looks like the docs weren't updated by snap. Ran freshdocs, should be good now.

@npm-robot
Copy link
Contributor

npm-robot commented May 10, 2022

found 1 benchmarks with statistically significant performance regressions

  • app-medium: lock-only
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 43.748 ±0.11 27.069 ±0.33 15.522 ±0.14 18.065 ±0.85 2.549 ±0.02 2.504 ±0.03 1.996 ±0.01 10.332 ±0.06 1.996 ±0.01 2.886 ±0.00
#4879 53.001 ±9.65 27.256 ±0.13 15.401 ±0.13 18.081 ±0.77 2.566 ±0.08 2.514 ±0.00 2.003 ±0.01 10.357 ±0.06 2.013 ±0.01 3.267 ±0.48
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.907 ±0.00 21.104 ±0.08 11.362 ±0.08 12.421 ±0.03 2.320 ±0.00 2.306 ±0.02 2.043 ±0.01 7.523 ±0.02 1.917 ±0.01 2.586 ±0.01
#4879 36.472 ±2.18 27.008 ±0.02 11.719 ±0.01 12.508 ±0.39 2.357 ±0.06 2.316 ±0.02 2.050 ±0.00 7.652 ±0.03 1.893 ±0.01 2.660 ±0.06

@fritzy fritzy force-pushed the fritzy/deprecations branch from 08e0689 to 9b8dcd6 Compare May 10, 2022 18:03
@fritzy
Copy link
Contributor Author

fritzy commented May 10, 2022

added instructions to set-script warning to use npm pkg set script:scriptname=cmd

@fritzy fritzy force-pushed the fritzy/deprecations branch 3 times, most recently from b0217aa to 8dbfff0 Compare May 10, 2022 18:57
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor tweaks

lib/utils/config/definitions.js Outdated Show resolved Hide resolved
lib/commands/set-script.js Outdated Show resolved Hide resolved
docs/content/commands/npm-config.md Outdated Show resolved Hide resolved
@fritzy fritzy force-pushed the fritzy/deprecations branch 2 times, most recently from 809d9ff to d103848 Compare May 18, 2022 19:36
@fritzy fritzy force-pushed the fritzy/deprecations branch from d103848 to 521ade2 Compare May 18, 2022 19:41
@fritzy fritzy merged commit 8898710 into latest May 18, 2022
@fritzy fritzy deleted the fritzy/deprecations branch May 18, 2022 22:13
@fritzy fritzy mentioned this pull request May 18, 2022
@lukekarrys lukekarrys mentioned this pull request May 25, 2022
akikanellis added a commit to akikanellis/homelab that referenced this pull request Jan 4, 2023
npm first [deprecated](npm/cli#4879)
but has since [undeprecated](npm/cli#4982) it.
akikanellis added a commit to akikanellis/homelab that referenced this pull request Jan 4, 2023
`npm bin` was removed as part of npm [v9.0.0](https://github.com/npm/cli/releases/tag/v9.0.0).

Also npm first [deprecated](npm/cli#4879) `--global` but has since [undeprecated](npm/cli#4982) it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants