Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lk/deps #4786

Merged
merged 12 commits into from
Apr 26, 2022
Merged

lk/deps #4786

merged 12 commits into from
Apr 26, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 20, 2022

@lukekarrys lukekarrys requested a review from a team as a code owner April 20, 2022 22:33
@npm-robot
Copy link
Contributor

npm-robot commented Apr 20, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 58.061 ±0.88 37.505 ±0.09 23.008 ±0.38 26.648 ±0.34 3.888 ±0.13 3.802 ±0.09 3.034 ±0.04 15.499 ±0.24 2.962 ±0.01 4.375 ±0.15
#4786 69.360 ±12.93 39.255 ±0.26 23.497 ±0.27 26.232 ±0.77 3.828 ±0.06 4.040 ±0.12 3.073 ±0.08 15.944 ±0.24 3.018 ±0.05 4.569 ±0.30
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.209 ±1.25 29.055 ±0.59 16.726 ±0.15 17.930 ±0.06 3.539 ±0.01 3.458 ±0.09 3.104 ±0.04 11.893 ±0.02 2.991 ±0.02 3.891 ±0.01
#4786 52.937 ±13.49 29.339 ±0.31 16.931 ±0.33 18.395 ±0.25 3.536 ±0.06 3.609 ±0.07 3.229 ±0.11 11.373 ±0.18 2.915 ±0.04 3.937 ±0.02

@lukekarrys lukekarrys force-pushed the lk/deps branch 4 times, most recently from badd195 to 694d4c9 Compare April 21, 2022 03:19
@lukekarrys lukekarrys marked this pull request as draft April 21, 2022 05:00
@lukekarrys
Copy link
Contributor Author

This needs to wait until two more patches land and are published:

@lukekarrys lukekarrys marked this pull request as ready for review April 21, 2022 16:31
@ruyadorno ruyadorno merged commit 9ea2603 into latest Apr 26, 2022
@ruyadorno ruyadorno deleted the lk/deps branch April 26, 2022 20:27
@ruyadorno ruyadorno mentioned this pull request Apr 26, 2022
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants