chore: remove hard set tap colors #4689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fact that tests fail here seems like a bug in testing and/or NPM. The tests all appear to be trying to set color but that isn't always translating to the output. |
|
found 1 benchmarks with statistically significant performance regressions
timing results
|
wraithgar
force-pushed
the
gar/tap-color-test
branch
from
6e7c0d6
to
2dd7775
Compare
wraithgar
force-pushed
the
gar/tap-color-test
branch
from
2dd7775
to
bef462e
Compare
The original PR #2225 indicated that this would prevent snapshot failures in CI with no color, but I hard set this to "0" and ran tests and they passed. This will make debugging tests in CI environments like the Node.js CITGM much easier. The reason for the failures is because even if we hard set environment variables in tests to force color one way or another, chalk has already made up its mind so changing those in the same process won't affect anything. The fix is to hard set two values in the actual `npm test` script to make `chalk` and `supports-color` do what we need. The `sudo` test commands were also removed because we do not want to encourage running npm w/ sudo.
wraithgar
force-pushed
the
gar/tap-color-test
branch
from
bef462e
to
1330d16
Compare
|
I'll come back to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR #2225 indicated that this
would prevent snapshot failures in CI with no color, but I hard set this
to "0" and ran tests and they passed. This will make debugging tests in
CI environments like the Node.js CITGM much easier.