Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/validate npm package #4635

Merged
merged 3 commits into from
Mar 30, 2022
Merged

deps/validate npm package #4635

merged 3 commits into from
Mar 30, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar requested a review from a team as a code owner March 29, 2022 20:36
@npm-robot
Copy link
Contributor

npm-robot commented Mar 29, 2022

found 1 benchmarks with statistically significant performance regressions

  • app-medium: clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 56.943 ±1.33 36.018 ±0.31 22.127 ±0.86 24.707 ±0.75 3.579 ±0.06 3.859 ±0.16 2.924 ±0.02 14.718 ±0.39 2.903 ±0.02 4.031 ±0.05
#4635 59.611 ±2.41 35.397 ±0.24 22.063 ±0.49 25.033 ±0.92 3.674 ±0.03 3.729 ±0.01 2.956 ±0.02 15.497 ±0.01 2.986 ±0.02 4.247 ±0.18
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 42.021 ±1.05 27.480 ±0.63 15.890 ±0.17 16.954 ±0.23 3.279 ±0.00 3.348 ±0.04 2.952 ±0.11 10.837 ±0.22 2.772 ±0.03 3.664 ±0.07
#4635 46.922 ±0.70 27.470 ±0.20 16.225 ±0.16 17.334 ±0.34 3.442 ±0.02 3.435 ±0.00 3.044 ±0.08 11.042 ±0.06 2.861 ±0.03 3.927 ±0.07

@lukekarrys lukekarrys force-pushed the deps/validate-npm-package branch from 0a25271 to bd40206 Compare March 30, 2022 00:16
@lukekarrys lukekarrys merged commit 5b4cbb2 into latest Mar 30, 2022
@lukekarrys lukekarrys deleted the deps/validate-npm-package branch March 30, 2022 06:50
@lukekarrys lukekarrys mentioned this pull request Mar 31, 2022
@lukekarrys lukekarrys mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants