-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set proper workspace repo urls in package.json #4476
Conversation
Good catch! It looks like we should fix this for all the workspaces: // npm pkg get repository -ws --include-workspace-root
{
"npm": {
"type": "git",
"url": "https://github.com/npm/cli"
},
"docs": {
"type": "git",
"url": "https://github.com/npm/cli"
},
"@npmcli/arborist": {
"type": "git",
"url": "https://github.com/npm/arborist"
},
"libnpmaccess": {
"type": "git",
"url": "https://github.com/npm/libnpmaccess.git"
},
"libnpmdiff": "https://github.com/npm/libnpmdiff",
"libnpmexec": "https://github.com/npm/libnpmexec",
"libnpmfund": "https://github.com/npm/libnpmfund",
"libnpmhook": "https://github.com/npm/libnpmhook",
"libnpmorg": {
"type": "git",
"url": "https://github.com/npm/libnpmorg.git"
},
"libnpmpack": {
"type": "git",
"url": "https://github.com/npm/libnpmpack.git"
},
"libnpmpublish": {
"type": "git",
"url": "https://github.com/npm/cli.git"
},
"libnpmsearch": {
"type": "git",
"url": "https://github.com/npm/libnpmsearch.git"
},
"libnpmteam": {
"type": "git",
"url": "https://github.com/npm/libnpmteam.git"
},
"libnpmversion": {
"type": "git",
"url": "git+https://github.com/npm/libnpmversion"
}
} |
If there's a single npm command that could set those, including the proper directory field, I'd be happy to update this PR with that result :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for now, and will serve as a test that it doesn't get changed when npm/template-oss#66 gets implemented.
Went ahead and manually updated it.
|
Waiting on |
v5 was published 2 days ago but still points to the archived repo.