Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor get package name #3331

Merged
merged 1 commit into from
May 28, 2021
Merged

fix: refactor get package name #3331

merged 1 commit into from
May 28, 2021

Commits on May 28, 2021

  1. fix: refactor get package name 

    renames read-local-package to read-package-name

The global check needed to be moved outside this function, because it
was handled differently (and will be even moreso when we implement diff
workspaces) in each function.  This allowed us to now pass in the prefix
itself instead of the npm object, so we can reuse this function to look
up package names when we refactor npm diff for workspaces.

PR-URL: #3331
Credit: @wraithgar
Close: #3331
Reviewed-by: @ruyadorno
    @wraithgar @ruyadorno
    wraithgar authored and ruyadorno committed May 28, 2021
    Configuration menu
    Copy the full SHA
    09f9d2e View commit details
    Browse the repository at this point in the history