Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uninstall): use correct local prefix #2930

Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix(uninstall): use correct local prefix #2930

merged 1 commit into from
Mar 24, 2021

Conversation

jameschensmith
Copy link
Contributor

Summary

A commit was made in v7.7.0, which removed references to flatOptions in favor of a more unified config. This caused a bug where this.npm.config.get('prefix') was using the global prefix.

This request corrects the non-global prefix path by using this.npm.localPrefix, a location already used throughout the repository (in the same file, in lib/prefix.js, etc.). Later, this value can be taken from the unified config library.

References

Fixes #2927.

@jameschensmith jameschensmith requested a review from a team as a code owner March 24, 2021 02:27
ruyadorno
ruyadorno reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks great! ❤️

can you please also add a npm.localPrefix = '' declaration in L24 along with the other resets? that will avoid carrying the path of a fixture to an unintended test in the future.

@jameschensmith
Copy link
Contributor Author

Done 🙂 Thanks for spotting that!

@ruyadorno ruyadorno linked an issue Mar 24, 2021 that may be closed by this pull request
[BUG] EACCES error with npm remove on [email protected] #2928
Closed
@ruyadorno
fix(uninstall): use correct local prefix
543b0e3 
Corrects non-global prefix path by using this.npm.localPrefix. A
location already used throughout the repository. Later, this will be
taken from the unified config library.

Signed-off-by: James Chen-Smith <[email protected]>

PR-URL: #2930
Credit: @jameschensmith
Close: #2930
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno changed the base branch from latest to release-next March 24, 2021 14:41
@ruyadorno ruyadorno merged commit 543b0e3 into npm:release-next Mar 24, 2021
@ruyadorno ruyadorno mentioned this pull request Mar 24, 2021
Merged
@jameschensmith jameschensmith deleted the jameschensmith/fix/non-global-uninstalls branch March 24, 2021 15:12
@ruyadorno ruyadorno mentioned this pull request Mar 24, 2021
Closed
@MrBrain295 MrBrain295 mentioned this pull request Oct 29, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Oct 29, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 30, 2023
Open
@mtdev2 mtdev2 mentioned this pull request Nov 30, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Nov 30, 2023
Open
@Theo13111 Theo13111 mentioned this pull request Nov 30, 2023
Open
@Billywildhig Billywildhig mentioned this pull request Nov 30, 2023
Open
@311821105 311821105 mentioned this pull request Nov 30, 2023
Open
@Billywildhig Billywildhig mentioned this pull request Dec 1, 2023
Open
@baby636 baby636 mentioned this pull request Dec 1, 2023
Open
@EMWickd EMWickd mentioned this pull request Dec 1, 2023
Open
@kingjay66 kingjay66 mentioned this pull request Dec 1, 2023
Open
@EMWickd EMWickd mentioned this pull request Dec 1, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Dec 1, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Dec 1, 2023
Merged
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
@311821105 311821105 mentioned this pull request Feb 11, 2024
Open
@CALISOULB CALISOULB mentioned this pull request Feb 11, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request Feb 11, 2024
Open
@Mary12jo33 Mary12jo33 mentioned this pull request Feb 11, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 11, 2024
Open
@f4lco0n f4lco0n mentioned this pull request Feb 11, 2024
Open
@hojatA1 hojatA1 mentioned this pull request Feb 11, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 11, 2024
Open
@hojatA1 hojatA1 mentioned this pull request Feb 12, 2024
Open
@Alfred182 Alfred182 mentioned this pull request Feb 12, 2024
Open
@311821105 311821105 mentioned this pull request Feb 12, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 12, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Feb 12, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@Theo13111 Theo13111 mentioned this pull request Feb 12, 2024
Open
@TheManager73 TheManager73 mentioned this pull request Feb 12, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Feb 12, 2024
Open
@mtdev2 mtdev2 mentioned this pull request May 20, 2024
Open
@baby636 baby636 mentioned this pull request May 21, 2024
Open
@bumplzz69 bumplzz69 mentioned this pull request May 21, 2024
Open
@Bhanditz Bhanditz mentioned this pull request May 21, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] EACCES error with npm remove on [email protected] [BUG] npm uninstall doesn't work in 7.7.0
2 participants
@jameschensmith @ruyadorno