Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(configuring-npm): Fix broken link #2860

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

varmakarthik12
Copy link

This fixes a broken link on the configuring-npm docs

A broken link confuses the person referring to the docs.

References

@varmakarthik12 varmakarthik12 requested a review from a team as a code owner March 13, 2021 12:14
@@ -562,8 +562,7 @@ tarball or git URL.
**Please do not put test harnesses or transpilers or other "development"
time tools in your `dependencies` object.** See `devDependencies`, below.

See [semver]([/using-npm/semver](https://github.com/npm/node-semver#versions))
for more details about specifying version ranges.
See [semver](/using-npm/semver) for more details about specifying version ranges.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [semver](/using-npm/semver) for more details about specifying version ranges.
See [semver](/using-npm/semver#versions) for more details about specifying version ranges.

@wraithgar wraithgar added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Mar 15, 2021
@wraithgar
Copy link
Member

Thank you for making this PR to update a broken link. I added a suggestion to keep the #versions part of the link, as that goes to the relevant section that this part of the readme is alluding to.

@varmakarthik12
Copy link
Author

Thank you for making this PR to update a broken link. I added a suggestion to keep the #versions part of the link, as that goes to the relevant section that this part of the readme is alluding to.

Taken care

@ruyadorno ruyadorno changed the base branch from latest to release-next March 18, 2021 20:13
@ruyadorno ruyadorno merged commit ad65bd9 into npm:release-next Mar 18, 2021
This was referenced Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants