Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "collective" property as fallback fo "funding" #284

Closed
wants to merge 1 commit into from

Conversation

znarf
Copy link

@znarf znarf commented Nov 5, 2019

Following up on a comment I shared here: #273 (review)

There are many packages using the collective property today to expose their Open Collective URL. Would be great to support that when funding is not found. While we wait for maintainers to add it.

The syntax of collective is similar to the one of funding, making the implementation uncomplicated.

It's also nice that this allow anyone to test the new npm fund feature and see results today, while in the current state it's giving (at least for me) only empty results for all the projects I tested.

@znarf znarf requested a review from a team as a code owner November 5, 2019 20:40
@ljharb
Copy link
Contributor

ljharb commented Nov 5, 2019

This seems like it's highly privileging one funding mechanism, effectively forever, and removing any incentive for OpenCollective-backed projects to switch to "funding".

@znarf
Copy link
Author

znarf commented Nov 6, 2019

@ljharb Understand your point. The goal is just to leverage prior art and make the fund command more useful from day one. Forever? That can be dropped after a few releases if this is a problem.

Anyway, at Open Collective, we will actively engage to make the funding property a success. We already notified maintainers about it, wrote a blog post https://blog.opencollective.com/beyond-post-install/ and will integrate it in our onboarding tools.

@ljharb
Copy link
Contributor

ljharb commented Nov 6, 2019

Dropping it would be semver-major; and the ecosystem thrash would likely make it not worth it to ever do so. There’s a bunch of github-specific things in npm that aren’t likely to ever go away, for example.

@isaacs
Copy link
Contributor

isaacs commented Nov 6, 2019

Yeah, I think @ljharb is right on this one. npm is community infrastructure, and that makes it tend to accrete features and never give them up.

While it'd be lovely to presume that this change could be temporary, it's unlikely to remain temporary once it's in use. If it works, people will use it, and then making it not work will break their workflow. Better to stick with the future-proof approach from day one. The long-term costs of removing it later outweigh the short-term benefits of faster uptake today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants