Fixed: npm publish lifecycle order

[CxRes]

The lifecycle order for npm publish was corrected to match actual behavior and no longer contradicts the description for prepare .

[CxRes]

This change needs to be backported as well!

[wraithgar]

We may need to take a slightly closer look at this, because unless I'm missing something prepublish isn't run during publish, and there are comments in both install and ci saying "should we remove this finally?" for prepublish.

[CxRes]

@wraithgar Do something very simple. In your package.json:

{
  ...
  scripts: {
    ...
    "prepublish": "echo prepublish",
    "prepublishOnly": "echo prepublishOnly",
    "prepare": "echo prepare"
    }
}

and run:

npm publish . --dry-run 

[CxRes]

prepublish is meant to behave at some point in the future like prepublishOnly and no longer like prepare. Thats for npm people to decide, but the documentation bug about behaviour today should be fixed now!

[wraithgar]

What version of npm are you using?

~/D/n/foo $ npm publish . --loglevel silent --dry-run

> [email protected] prepublishOnly
> echo prepublishOnly

prepublishOnly
~/D/n/foo $ npm -v
7.5.2
~/D/n/foo $ cat package.json|json scripts
{
  "prepublish": "echo prepublish",
  "prepublishOnly": "echo prepublishOnly",
  "prepare": "echo prepare"
}

[CxRes]

@wraithgar I am on 6.14.10 (shipped with node 14.15.4). That explains the difference we are seeing, (except it doesn't solve the matter but actually makes things worse, see below)!

output with 6.14.10

prepublish
prepare
prepublishOnly

output with 7.5.2

prepublishOnly

Note that prepare not showing up either in v7. Have both prepare and prepublish been removed from the publish lifecycle? If this is correct behaviour, it is an undocumented breaking change.

[wraithgar]

Prepare runs, but its output is suppressed, and it doesn't run during a dry-run.

We did a quick spike to investigate and document the lifecycle scripts, and the initial research is done. Now all that's left is getting the docs up to date to reflect reality, and reflect all of it.

npm/statusboard#267

[wraithgar]

Saving you a click, here's what runs during publish

• prepublishOnly
• prepack
• prepare (not during dry-run)
• postpack
• publish
• postpublish

[CxRes]

Just to confirm, in that order? because it is different from 6.x?

[wraithgar]

Yes this is the order in which lifecycle events happen during publish in npm@7

[wraithgar]

This change and many other is going to be reflected in #2690