pass extra arguments directly to run-script as an array #2448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we're appending everything passed as an argument to npx/npm exec together into one single large string. this is rarely the correct thing to do. rather than re-adding the argument escaping here, i decided to fix it correctly and pass any additional arguments past the name of the command/script to run as an array literal to @npmcli/run-script which can handle the escaping appropriately and consistently there.
References
fixes #2410
fixes #2423
fixes #2425