Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: v7 npm-install refresh #1911

Closed

Conversation

ruyadorno
Copy link
Contributor

Initiall pass at refreshing the npm-install docs for npm7

@ruyadorno ruyadorno requested a review from a team as a code owner October 7, 2020 01:58
@ruyadorno ruyadorno added the Release 7.x work is associated with a specific npm 7 release label Oct 7, 2020
@ruyadorno ruyadorno force-pushed the docs-npm-install-npm7-refresh branch from 28d8cc6 to b631b16 Compare October 7, 2020 14:55
Initiall pass at refreshing the npm-install docs for npm7
@ruyadorno ruyadorno force-pushed the docs-npm-install-npm7-refresh branch from b631b16 to ebe5d23 Compare October 7, 2020 16:03
@ruyadorno ruyadorno mentioned this pull request Oct 7, 2020
5 tasks
@ruyadorno ruyadorno added this to the OSS - Sprint 17 milestone Oct 7, 2020
@ruyadorno ruyadorno self-assigned this Oct 7, 2020
installation of dependencies will be driven by that, respecting the following
order of precedence:

* `node_modules/.package-lock.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that even if i have package-lock=false in npmrc, rm -rf node_modules && npm install will no longer always fetch the latest of everything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well if you rm -rf node_modules first then the file is getting deleted along with the folder so it will still behave the same 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and if i rm -rf node_modules/* && npm install, as i always do, since i have the node_modules dir ignored by dropbox and i don't want to lose that setting by deleting the folder? (which won't remove dotfiles)

Copy link
Contributor Author

@ruyadorno ruyadorno Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right right, yeah in that case it might not work as before but hey, the good news is that npm update (no args) should provide that functionality out of the box in npm7 and you won't need that convoluted workflow anymore! 😁

darcyclarke pushed a commit that referenced this pull request Oct 12, 2020
Initiall pass at refreshing the npm-install docs for npm7

PR-URL: https://github.com/Usage:
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url>
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin]
(will read url/id from clipboard if not specified)
Credit: @
Close: #1911
Reviewed-by: @darcyclarke
darcyclarke pushed a commit that referenced this pull request Oct 12, 2020
Initiall pass at refreshing the npm-install docs for npm7

PR-URL: https://github.com/Usage:
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url>
  /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin]
(will read url/id from clipboard if not specified)
Credit: @ruyadorno
Close: #1911
Reviewed-by: @darcyclarke
@isaacs isaacs closed this in 5bc7eb2 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants