Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listing deps of a linked dep #1871

Closed

Conversation

ruyadorno
Copy link
Contributor

npm ls was failing to properly follow symlink targets in order to find its dependencies to get printed output.

npm ls was failing to properly follow symlink targets in order to find
its dependencies to get printed output.
@ruyadorno ruyadorno requested a review from a team as a code owner September 28, 2020 18:52
@ruyadorno ruyadorno added beta Release 7.x work is associated with a specific npm 7 release labels Sep 28, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 16 milestone Sep 28, 2020
@ruyadorno ruyadorno self-assigned this Sep 28, 2020
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nlf pushed a commit that referenced this pull request Sep 29, 2020
npm ls was failing to properly follow symlink targets in order to find
its dependencies to get printed output.

PR-URL: #1871
Credit: @ruyadorno
Close: #1871
Reviewed-by: @nlf
nlf pushed a commit that referenced this pull request Sep 29, 2020
npm ls was failing to properly follow symlink targets in order to find
its dependencies to get printed output.

PR-URL: #1871
Credit: @ruyadorno
Close: #1871
Reviewed-by: @nlf
@ruyadorno ruyadorno closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants