Add a 'check-coverage' script so we can track towards completion #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the CLI portion of npm/arborist#136
isaacs
force-pushed
the
isaacs/check-coverage
branch
2 times, most recently
from
f874d26 to
cdf708c
Compare
We are targetting 100% test coverage for npm v7 GA. Using a coverage-map, we require that any of the newly created tests fully cover the module that they are testing. However, this has the side effect of _always_ hitting 100% coverage when running 'npm test', even though not all modules are being tested. This adds a new 'load-all' test which, in 'check-coverage' mode, tells nyc to include every file in the project. This also removes the double-run of our tests in CI, where we run once and then immediately run the same exact thing again for Coveralls, and sends the 'check-coverage' output to Coveralls instead.
isaacs
force-pushed
the
isaacs/check-coverage
branch
from
cdf708c to
1922ef8
Compare
darcyclarke
added
semver:major
nlf
approved these changes
Sep 21, 2020
ruyadorno
pushed a commit
that referenced
this pull request
Sep 22, 2020
We are targetting 100% test coverage for npm v7 GA. Using a coverage-map, we require that any of the newly created tests fully cover the module that they are testing. However, this has the side effect of _always_ hitting 100% coverage when running 'npm test', even though not all modules are being tested. This adds a new 'load-all' test which, in 'check-coverage' mode, tells nyc to include every file in the project. This also removes the double-run of our tests in CI, where we run once and then immediately run the same exact thing again for Coveralls, and sends the 'check-coverage' output to Coveralls instead. PR-URL: #1820 Credit: @isaacs Close: #1820 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on #1819, land that first.)
We are targetting 100% test coverage for npm v7 GA. Using a
coverage-map, we require that any of the newly created tests fully cover
the module that they are testing. However, this has the side effect of
always hitting 100% coverage when running 'npm test', even though not
all modules are being tested.
This adds a new 'load-all' test which, in 'check-coverage' mode, tells
nyc to include every file in the project.
This also removes the double-run of our tests in CI, where we run once
and then immediately run the same exact thing again for Coveralls, and
sends the 'check-coverage' output to Coveralls instead.