Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated: fix special 'remote' deps #180

Closed
wants to merge 2 commits into from
Closed

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Mar 23, 2019

Add a special case for 'remote' deps (tarballs). Before b7b54f2 the package names were just looked up in the registry instead. The errors caused by that were hidden by npm-pick-manifest not returning the ETARGET error that outdated expects.

See https://npm.community/t/6187

Add a special case for 'remote' deps (tarballs). Before 
b7b54f2 the package names were possibly 
just looked up in the registry instead.

See https://npm.community/t/6187
@larsgw larsgw requested a review from a team as a code owner March 23, 2019 01:27
@et304383
Copy link

et304383 commented May 6, 2019

What is holding this up?

Are there no CI/CD tests that get run before merging changes to npm? Trying to understand how something so important as npm update was broken with no one noticing.

isaacs pushed a commit that referenced this pull request Jun 28, 2019
Add a special case for 'remote' deps (tarballs). Before
b7b54f2 the package names were possibly
just looked up in the registry instead.

See https://npm.community/t/6187

Close: #180
isaacs pushed a commit that referenced this pull request Jun 29, 2019
Add a special case for 'remote' deps (tarballs). Before
b7b54f2 the package names were possibly
just looked up in the registry instead.

See https://npm.community/t/6187

Close: #180
@0xsuid
Copy link

0xsuid commented Jun 29, 2019

@isaacs any update on this issue??

@larsgw
Copy link
Contributor Author

larsgw commented Jun 29, 2019

It seems to be merged indirectly (7f8d52e) and will probably be included in the next release.

@isaacs
Copy link
Contributor

isaacs commented Jun 29, 2019

Yes, It's in the release-next-6.10.0 branch, and will be in 6.10.0.

@isaacs isaacs closed this in ce93dab Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants