explain-dep: handle shortening edge from root project

Fixes: #2134
npm · Nov 11, 2020 · cb3d489 · cb3d489
1 parent 5ae21e4
commit cb3d489
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/lib/utils/explain-dep.js b/lib/utils/explain-dep.js
@@ -64,7 +64,7 @@ const explainDependents = ({ name, dependents }, depth, color) => {
     const maxLen = 50
     const showNames = []
     for (let i = max; i < dependents.length; i++) {
-      const { from: { name } } = dependents[i]
+      const { from: { name = 'the root project' } } = dependents[i]
       len += name.length
       if (len >= maxLen && i < dependents.length - 1) {
         showNames.push('...')

diff --git a/tap-snapshots/test-lib-utils-explain-dep.js-TAP.test.js b/tap-snapshots/test-lib-utils-explain-dep.js-TAP.test.js
@@ -10,15 +10,15 @@ [email protected]
   manydep@"1.0.0" from [email protected]
   node_modules/prod-dep
     prod-dep@"1.x" from the root project
-  6 more (optdep, extra-neos, deep-dev, peer, ...)
+  7 more (optdep, extra-neos, deep-dev, peer, the root project, ...)
 `
 
 exports[`test/lib/utils/explain-dep.js TAP > ellipses test two 1`] = `
 [email protected]
   manydep@"1.0.0" from [email protected]
   node_modules/prod-dep
     prod-dep@"1.x" from the root project
-  5 more (optdep, extra-neos, deep-dev, peer, a package with a pretty long name)
+  6 more (optdep, extra-neos, deep-dev, peer, the root project, a package with a pretty long name)
 `
 
 exports[`test/lib/utils/explain-dep.js TAP deepDev > explain color deep 1`] = `
@@ -90,6 +90,7 @@ exports[`test/lib/utils/explain-dep.js TAP manyDeps > explain color deep 1`] = `
   [35mpeer[39m [1mmanydep[22m@"[1m>1.0.0-beta <1.0.1[22m" from [1mpeer[22m@[1m1.0.0[22m [1m[35mpeer[39m[22m[2m[22m
   [2mnode_modules/peer[22m
     [35mpeer[39m [1mpeer[22m@"[1m1.0.0[22m" from the root project
+  [1mmanydep[22m@"[1m>1.0.0-beta <1.0.1[22m" from the root project
   [1mmanydep[22m@"[1m1[22m" from [1ma package with a pretty long name[22m@[1m1.2.3[22m
   [1mmanydep[22m@"[1m1[22m" from [1manother package with a pretty long name[22m@[1m1.2.3[22m
   [1mmanydep[22m@"[1m1[22m" from [1myet another a package with a pretty long name[22m@[1m1.2.3[22m
@@ -100,7 +101,7 @@ [email protected]
   manydep@"1.0.0" from [email protected]
   node_modules/prod-dep
     prod-dep@"1.x" from the root project
-  7 more (optdep, extra-neos, deep-dev, peer, ...)
+  8 more (optdep, extra-neos, deep-dev, peer, the root project, ...)
 `
 
 exports[`test/lib/utils/explain-dep.js TAP manyDeps > print color 1`] = `

diff --git a/test/lib/utils/explain-dep.js b/test/lib/utils/explain-dep.js
@@ -140,6 +140,14 @@ cases.manyDeps = {
       spec: '>1.0.0-beta <1.0.1',
       from: cases.peer,
     },
+    {
+      type: 'prod',
+      name: 'manydep',
+      spec:'>1.0.0-beta <1.0.1',
+      from: {
+        location: '/path/to/project',
+      },
+    },
     {
       type: 'prod',
       name: 'manydep',