Skip to content

Commit

Permalink
chore(node-pr): various fixes and updates for the node PR script (#5817)
Browse files Browse the repository at this point in the history
  • Loading branch information
lukekarrys authored Nov 7, 2022
1 parent ef42996 commit 93bd6d1
Show file tree
Hide file tree
Showing 9 changed files with 1,508 additions and 240 deletions.
97 changes: 0 additions & 97 deletions .github/workflows/create-cli-deps-pr.yml

This file was deleted.

8 changes: 7 additions & 1 deletion .github/workflows/create-node-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
description: "The npm spec to create the PR from"
required: true
default: 'latest'
branch:
description: "The major node version to serve as the base of the PR. Should be `main` or a number like `18`, `19`, etc."
required: true
default: 'main'
dryRun:
description: "Setting this to anything will run all the steps except opening the PR"

Expand All @@ -23,6 +27,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Setup Git User
run: |
git config --global user.email "[email protected]"
Expand All @@ -46,4 +52,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.NODE_PULL_REQUEST_TOKEN }}
run: |
DRY_RUN=$([ -z "${{ inputs.dryRun }}" ] && echo "" || echo "--dry-run")
node scripts/create-node-pr.js "${{ inputs.spec }}" "$DRY_RUN"
node scripts/create-node-pr.js ${{ inputs.spec }} ${{ inputs.branch }} "$DRY_RUN"
3 changes: 3 additions & 0 deletions DEPENDENCIES.md
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,9 @@ graph LR;
npm-->read-package-json;
npm-->read;
npm-->readdir-scoped-modules;
npm-->remark-gfm;
npm-->remark-github;
npm-->remark;
npm-->rimraf;
npm-->semver;
npm-->smoke-tests;
Expand Down
Loading

0 comments on commit 93bd6d1

Please sign in to comment.