Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-implement skipped windows test #95

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 1, 2024

Using socksv5 now for setting up a small socks proxy server in tests. This library works on Node 18 and 20 which previously were skipped due to a bug in simple-socks.

@lukekarrys lukekarrys requested a review from a team as a code owner April 1, 2024 20:01
@lukekarrys lukekarrys changed the title lk/weird windows test chore: re-implement skipped windows test Apr 1, 2024
@wraithgar wraithgar merged commit f797fa1 into main Apr 4, 2024
21 checks passed
@wraithgar wraithgar deleted the lk/weird-windows-test branch April 4, 2024 16:07
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
hashtagchris pushed a commit that referenced this pull request Aug 26, 2024
🤖 I have created a release *beep* *boop*
---


## [3.0.0](v2.2.2...v3.0.0)
(2024-08-26)

### ⚠️ BREAKING CHANGES

* `@npmcli/agent` now supports node `^18.17.0 || >=20.5.0`

### Bug Fixes

*
[`5dbeb55`](5dbeb55)
[#113](#113) align to npm 10 node
engine range (@hashtagchris)

### Chores

*
[`bfdccc1`](bfdccc1)
[#114](#114) bump @npmcli/eslint-config
from 4.0.5 to 5.0.0 (@dependabot[bot])
*
[`e3fd27f`](e3fd27f)
[#113](#113) run template-oss-apply
(@hashtagchris)
*
[`21c1987`](21c1987)
[#99](#99) linting: no-unused-vars
(@lukekarrys)
*
[`488db1d`](488db1d)
[#99](#99) bump @npmcli/template-oss to
4.22.0 (@lukekarrys)
*
[`f797fa1`](f797fa1)
[#95](#95) re-implement skipped windows
test (#95) (@lukekarrys)
*
[`603173b`](603173b)
[#111](#111) postinstall for dependabot
template-oss PR (@hashtagchris)
*
[`0c7400c`](0c7400c)
[#111](#111) bump @npmcli/template-oss
from 4.22.0 to 4.23.1 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants