Skip to content

Commit

Permalink
Revert "[url_launcher] Set broadcast reciever visability as required …
Browse files Browse the repository at this point in the history
  • Loading branch information
reidbaker authored and nploi committed Jul 16, 2023
1 parent b7a857f commit 568e8bb
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 16 deletions.
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.0.34

* Reverts ContextCompat usage that caused flutter/flutter#127014

## 6.0.33

* Explicitly sets if reciever for close should be exported.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,9 @@ android {
}

dependencies {
def core_version = "1.10.1"

// Java language implementation
implementation "androidx.core:core:$core_version"

compileOnly 'androidx.annotation:annotation:1.2.0'
testImplementation 'junit:junit:4.13.2'
testImplementation 'org.mockito:mockito-core:5.1.1'
testImplementation 'androidx.test:core:1.0.0'
testImplementation 'org.robolectric:robolectric:4.4.1'

// org.jetbrains.kotlin:kotlin-bom artifact purpose is to align kotlin stdlib and related code versions.
// See: https://youtrack.jetbrains.com/issue/KT-55297/kotlin-stdlib-should-declare-constraints-on-kotlin-stdlib-jdk8-and-kotlin-stdlib-jdk7
implementation(platform("org.jetbrains.kotlin:kotlin-bom:1.8.10"))
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import androidx.annotation.Nullable;
import androidx.annotation.RequiresApi;
import androidx.annotation.VisibleForTesting;
import androidx.core.content.ContextCompat;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
Expand Down Expand Up @@ -144,11 +143,7 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
webview.setWebChromeClient(new FlutterWebChromeClient());

// Register receiver that may finish this Activity.
ContextCompat.registerReceiver(
this.getApplication(),
broadcastReceiver,
closeIntentFilter,
ContextCompat.RECEIVER_EXPORTED);
registerReceiver(broadcastReceiver, closeIntentFilter);
}

@VisibleForTesting
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_android/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher_android
description: Android implementation of the url_launcher plugin.
repository: https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 6.0.33
version: 6.0.34

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down

0 comments on commit 568e8bb

Please sign in to comment.