New EF Core comment support #950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I may hold off merging this until dotnet/efcore#16798 is fixed, to cover all cases. |
YohDeadfall
approved these changes
Jul 28, 2019
test/EFCore.PG.FunctionalTests/NpgsqlMigrationSqlGeneratorTest.cs
Outdated
Show resolved
Hide resolved
| @@ -45,5 +44,8 @@ public static class NpgsqlAnnotationNames | |||
|
|
|||
| [Obsolete("Replaced by ValueGenerationStrategy.SerialColumn")] | |||
| public const string ValueGeneratedOnAdd = Prefix + "ValueGeneratedOnAdd"; | |||
|
|
|||
| [Obsolete("Replaced by built-in EF Core support")] | |||
There was a problem hiding this comment.
Makes sense to write a constant in this class with a value like "Replaced by built-in EF Core support. Use HasComment", and reuse it for all Obsolete attributes.
There was a problem hiding this comment.
I changed the obsolete messages to be more informative, but am keeping them separate since the ones on the builder should be much more concise/easy. The others (like this one in NpgsqlAnnotationNames) will likely not be seen by end users anyway.
austindrenski
approved these changes
Jul 29, 2019
|
Holding off on this until issues in the upstream implementation are fixed (dotnet/efcore#16819) |
|
Superceded by #992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #892