Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ProvidePasswordCallback to EFCore.PG #917

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Add support for ProvidePasswordCallback to EFCore.PG #917

merged 2 commits into from
Aug 29, 2019

Conversation

williamdenton
Copy link
Contributor

This repo has not been updated to use a new enough version (>4.1) of Npgsql yet for this to compile. I didn't want to charge ahead and do that as it seems outside the scope of this PR to do that upgrade, but it is required for this PR as it uses the new member ProvidePasswordCallback on NpgsqlConnection which was added in npgsql/npgsql#2502

@austindrenski
Copy link
Contributor

I didn't want to charge ahead and do that as it seems outside the scope of this PR to do that upgrade, but it is required for this PR

Appreciate the narrow approach you've taken, but feel free to add the upgrade as a separate (prepended) commit so that the CI tests build during review.

We can always drop or cherry-pick around it when it's time to merge.

@williamdenton

This comment has been minimized.

Directory.Build.props Outdated Show resolved Hide resolved
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks for plumbing this through the EF Core provider.

Missing: You also need to make the appropriate changes in NpgsqlOptionsExtension.cs.PopulateDebugInfo

@williamdenton
Copy link
Contributor Author

forced pushed the change to keep it easy to remove the 4.1 upgrade commit later

@williamdenton
Copy link
Contributor Author

Rebased on preview 7

@williamdenton
Copy link
Contributor Author

Looks like I need to fix this up more. I'm away for the next week then will get this sorted

@roji
Copy link
Member

roji commented Jul 25, 2019

Thanks for this extra work @williamdenton, take your time.

@williamdenton

This comment has been minimized.

@williamdenton

This comment has been minimized.

@williamdenton
Copy link
Contributor Author

williamdenton commented Aug 16, 2019

@roji I've rebased on latest dev and this looks like its passing now that npgsql 4.1 is referenced

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please rebase on the latest dev? I'm seeing some conflicts locally (which for some reason don't appear on github).

@williamdenton
Copy link
Contributor Author

@roji rebased on aa6809e

@roji roji merged commit e76f3bb into npgsql:dev Aug 29, 2019
@roji
Copy link
Member

roji commented Aug 29, 2019

Remerged via a2180f0 - the original merge somehow did not occur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants