-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ProvidePasswordCallback to EFCore.PG #917
Conversation
Appreciate the narrow approach you've taken, but feel free to add the upgrade as a separate (prepended) commit so that the CI tests build during review. We can always drop or cherry-pick around it when it's time to merge. |
This comment has been minimized.
This comment has been minimized.
test/EFCore.PG.Plugins.FunctionalTests/EFCore.PG.Plugins.FunctionalTests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks for plumbing this through the EF Core provider.
Missing: You also need to make the appropriate changes in NpgsqlOptionsExtension.cs.PopulateDebugInfo
test/EFCore.PG.FunctionalTests/TestUtilities/TestRelationalCommandBuilderFactory.cs
Outdated
Show resolved
Hide resolved
forced pushed the change to keep it easy to remove the 4.1 upgrade commit later |
Rebased on preview 7 |
Looks like I need to fix this up more. I'm away for the next week then will get this sorted |
Thanks for this extra work @williamdenton, take your time. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@roji I've rebased on latest dev and this looks like its passing now that npgsql 4.1 is referenced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you please rebase on the latest dev? I'm seeing some conflicts locally (which for some reason don't appear on github).
Remerged via a2180f0 - the original merge somehow did not occur? |
This repo has not been updated to use a new enough version (>4.1) of Npgsql yet for this to compile. I didn't want to charge ahead and do that as it seems outside the scope of this PR to do that upgrade, but it is required for this PR as it uses the new member
ProvidePasswordCallback
onNpgsqlConnection
which was added in npgsql/npgsql#2502