Added new NTS translations #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Geometry.Buffer(double, int) Added Geometry.InteriorPoint Added Geometry.OgcGeometryType Added Geometry.Union()
EricStG
requested review from
austindrenski,
roji and
YohDeadfall
as code owners
YohDeadfall
reviewed
Mar 17, 2019
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
…etTopologySuiteMemberTranslatorPlugin.cs Fixed indentation Co-Authored-By: EricStG <[email protected]>
YohDeadfall
reviewed
Mar 18, 2019
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
roji
requested changes
Mar 18, 2019
There was a problem hiding this comment.
One question to confirm from me, and otherwise agree with @YohDeadfall's comments.
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Show resolved
Hide resolved
roji
reviewed
Mar 19, 2019
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
YohDeadfall
approved these changes
Mar 20, 2019
austindrenski
suggested changes
Mar 30, 2019
...NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMethodCallTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
Reduced ST_Buffer case statements in NpgsqlGeometryMethodTranslator to one Removed superflous private modifier
austindrenski
approved these changes
Mar 31, 2019
|
Hi, just wondering what's missing here to close this? |
|
Nope nothing missing here! |
|
Thanks for your contribution (and patience) @EricStG! |
austindrenski
pushed a commit
that referenced
this pull request
May 21, 2019
- Geometry.Buffer(double, int) - Geometry.InteriorPoint - Geometry.OgcGeometryType - Geometry.Union()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Geometry.Buffer(double, int)Added
Geometry.InteriorPointAdded
Geometry.OgcGeometryTypeAdded
Geometry.Union()Contributes to #457