Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full text search documentation page #442

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

rwasef1830
Copy link
Contributor

@roji Here's the documentation page for full text search. Let me know what you think. This is a follow up to #1.

Copy link
Contributor

@YohDeadfall YohDeadfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,9 +2,149 @@

PostgreSQL has [built-in support for full-text search](https://www.postgresql.org/docs/current/static/textsearch.html), which allows you to conveniently and efficiently query natural language documents.

*TO BE COMPLETED*
## Mapping
PostgreSQL full text search types are mapped onto C# types built-in to Npgsql. The ```tsvector``` type is mapped to ```NpgsqlTsVector``` and ```tsquery``` is mapped to ```NpgsqlTsQuery```. This means you can use properties of type ```NpgsqlTsVector``` directly in your model to create ```tsvector``` columns. The ```NpgsqlTsQuery``` type on the other hand, is used in LINQ queries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe .NET types?

FYI, you can use single backticks to make inline code blocks (:

@rwasef1830 rwasef1830 force-pushed the full-text-search-docs branch 2 times, most recently from f818672 to 595794e Compare May 31, 2018 20:03
@rwasef1830
Copy link
Contributor Author

@YohDeadfall Wording updated, backticks adjusted.

@austindrenski
Copy link
Contributor

Just a comment on the identifier quoting:

Per the release notes:

Identifiers in generated SQL will only be quoted if needed (#327). This should make it much easier to read.

So this:

WHERE "c"."SearchVector" @@ 'Npgsql'

could be simplified to:

WHERE c."SearchVector" @@ 'Npgsql'

@rwasef1830 rwasef1830 force-pushed the full-text-search-docs branch from 595794e to bf42507 Compare June 1, 2018 11:41
@rwasef1830
Copy link
Contributor Author

@YohDeadfall No longer quoting "c".

@YohDeadfall
Copy link
Contributor

@austindrenski @rwasef1830 Thanks! I think it can be merged now.

@YohDeadfall YohDeadfall merged commit 1df1baa into npgsql:dev Jun 1, 2018
@rwasef1830 rwasef1830 deleted the full-text-search-docs branch June 1, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants