Array translation improvements #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
MoarArrayTranslations
branch
from
8370f16 to
856b46f
Compare
roji
force-pushed
the
MoarArrayTranslations
branch
from
856b46f to
1556d9a
Compare
And redo array/list tests Closes npgsql#2026
roji
force-pushed
the
MoarArrayTranslations
branch
from
1556d9a to
7cd18ec
Compare
hez2010
reviewed
Oct 8, 2021
| private static readonly MethodInfo SequenceEqual = | ||
| #region Methods | ||
|
|
||
| private static readonly MethodInfo Array_IndexOf1 = |
There was a problem hiding this comment.
I recommend using below code to get definite method overload.
typeof(Array).GetMethod(nameof(Array.IndexOf), 1, BindingFlags.Public | BindingFlags.Static | BindingFlags.DeclaredOnly, null, CallingConventions.Any, new[] { Type.MakeGenericMethodParameter(0).MakeArrayType(), Type.MakeGenericMethodParameter(0) }, null)There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And redo array/list tests
Closes #2026