-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying NULLS NOT DISTINCT for unique indexes #2298
Comments
Note: IIRC EF Core itself adds a nullability WHERE clause to indexes, that may become unnecessary here - investigate this. |
This is SqlServerIndexConvention, which works for unique non-clustered indexes for SQL Server only. |
Discussed with @AndriySvyryd about the possibility of a relational-level knob for this, which SqlServerIndexConvention would consult etc. We're not going to do this for now, since the implementation differences across providers (convention with index filter in SQL Server vs. native capability in PG) may have non-obvious consequences. So we'll just do a PG-specific index flag. |
Thanks for the update. I imagine it makes the most sense anyway to proof such an API w/ one provider, see how it goes, then consider upstream support based off that. |
Just FYI, am going to wait until a PG15 beta is available before implementing this, so that we can see it actually working in our CI. |
PostgreSQL 15 will allow specifying
NULLS NOT DISTINCT
on index columns, to make unique indexes disallow multiple rows with NULLs (see docs).Raised by @mqudsi in dotnet/efcore#16949 (comment).
The text was updated successfully, but these errors were encountered: