Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code literal generation for JsonElement #1101

Closed
roji opened this issue Oct 30, 2019 · 0 comments · Fixed by #1120
Closed

Code literal generation for JsonElement #1101

roji opened this issue Oct 30, 2019 · 0 comments · Fixed by #1120
Assignees
@roji
Labels
enhancement New feature or request
Milestone
3.1.0

Comments

@roji
Copy link
Member

roji commented Oct 30, 2019

In #1100 we added support for JsonDocument literal generation. Unfortunately, for JsonElement we need to call the non-static JsonDocument.RootElement property, which isn't yet supported by EF Core (dotnet/efcore#18655).
@roji roji added the enhancement New feature or request label Oct 30, 2019
@roji roji added this to the 3.1.0 milestone Oct 30, 2019
@roji roji self-assigned this Oct 30, 2019
@roji roji mentioned this issue Oct 30, 2019
Closed
@roji roji added the blocked label Oct 30, 2019
@roji roji removed the blocked label Nov 7, 2019
roji added a commit that referenced this issue Nov 7, 2019
@roji
Code literal generation for JsonElement
b331679 
Fixes #1101
@roji roji mentioned this issue Nov 7, 2019
Merged
@roji roji closed this as completed in #1120 Nov 7, 2019
roji added a commit that referenced this issue Nov 7, 2019
@roji
Code literal generation for JsonElement
5d53171 
Fixes #1101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Code literal generation for JsonElement npgsql/efcore.pg
1 participant
@roji