Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker-machine download URL appears to be inaccessible #457

Closed
JulianCBC opened this issue Mar 2, 2022 · 3 comments
Closed

Docker-machine download URL appears to be inaccessible #457

JulianCBC opened this issue Mar 2, 2022 · 3 comments
Labels
released

Comments

@JulianCBC
Copy link
Contributor

It appears that GitLab has made the "generic" https://gitlab-docker-machine-downloads.s3.amazonaws.com/VERSION/docker-machine URL inaccessible, so only the "fully qualified" URLs with a system type and architecture work.

$ curl https://gitlab-docker-machine-downloads.s3.amazonaws.com/v0.16.2-gitlab.12/docker-machine
<?xml version="1.0" encoding="UTF-8"?>
<Error><Code>AccessDenied</Code><Message>Access Denied</Message><RequestId>ENYDP0R4QVSFP0QC</RequestId><HostId>iJ7zVyel7aLWz4qEE0lMPpwXbItiAmiud1LkRzwbzts36AqLG1rvINDixGl4Qs2SvrJ1NL7cIYc=</HostId></Error>

$ curl https://gitlab-docker-machine-downloads.s3.amazonaws.com/v0.16.2-gitlab.12/docker-machine-Linux-x86_64 | file -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 59.8M  100 59.8M    0     0  1957k      0  0:00:31  0:00:31 --:--:-- 2982k
/dev/stdin: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=H8fu0C_uLjkoi-o2ao1v/Greq4F4710ptsLoOLyoB/6Hmp0aU-D8xXDMQeVDPz/wbFjEQ0zwCgSg31oPilA, not stripped

I think the simplest solution here would be to just switch the default over to specifying a version instead of a full URL as that appears to do the right thing, and will follow the architecture used on the coordinator EC2 instance without any further configuration.
@npalm
Copy link
Collaborator

npalm commented Mar 2, 2022

Thx, will do my best to revert it asap. Feel free to make a PR.

JulianCBC added a commit to JulianCBC/terraform-aws-gitlab-runner that referenced this issue Mar 2, 2022
@JulianCBC
fix: Default to a version instead of an explicit URL
2cce8dc 
GitLab has made the "generic" URLs which end in `/docker-machine`
inaccessible, so instead specify a version for docker-machine and use
the URL generation as that both produces URLs that work and should do
the right thing in most cases.

Fixes cattle-ops#457.
@JulianCBC JulianCBC mentioned this issue Mar 3, 2022
Merged
@ryancausey
Copy link
Contributor

Can confirm this issue prevents the runner from starting properly, so I've had to lock to version 4.40.0 for now, as well as manually setting gitlab_runner_version to something other than the default of "14.8.0" due to #456.

@npalm npalm closed this as completed in c8113bb Mar 7, 2022
semantic-releaser bot pushed a commit that referenced this issue Mar 7, 2022
@semantic-release-bot
chore(release): 4.41.1 [skip ci]
7a3370a 
### [4.41.1](4.41.0...4.41.1) (2022-03-07)

### Bug Fixes

* remove the null resource ([#441](#441)) ([3037c54](3037c54))
* Replace default GitLab version and fix for docker-machine download url. ([#458](#458)) ([c8113bb](c8113bb)), closes [#457](#457) [#456](#456)
@semantic-releaser
Copy link
Contributor

🎉 This issue has been resolved in version 4.41.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

npalm pushed a commit that referenced this issue Mar 7, 2022
@JulianCBC @npalm
fix: Replace default GitLab version and fix for docker-machine downlo…
da0c04d 
…ad url. (#458)

* feat: Switch to GitLab's forked docker-machine version

Update the version-generated URL to use the GitLab fork of
docker-machine as the official one is dead and buried.

* fix: Default to a version instead of an explicit URL

GitLab has made the "generic" URLs which end in `/docker-machine`
inaccessible, so instead specify a version for docker-machine and use
the URL generation as that both produces URLs that work and should do
the right thing in most cases.

Fixes #457.

* fix: Update runner version to 14.8.2

Version 14.8.0 had a major regression and was removed from all release
distribution channels. Update to 14.8.2 as that's the latest 14.8.x
version.

Fixes #456
npalm added a commit that referenced this issue May 17, 2022
@npalm
fix: Replace default GitLab version and fix for docker-machine downlo…
94c9a9b 
…ad url. (#458)

* feat: Switch to GitLab's forked docker-machine version

Update the version-generated URL to use the GitLab fork of
docker-machine as the official one is dead and buried.

* fix: Default to a version instead of an explicit URL

GitLab has made the "generic" URLs which end in `/docker-machine`
inaccessible, so instead specify a version for docker-machine and use
the URL generation as that both produces URLs that work and should do
the right thing in most cases.

Fixes #457.

* fix: Update runner version to 14.8.2

Version 14.8.0 had a major regression and was removed from all release
distribution channels. Update to 14.8.2 as that's the latest 14.8.x
version.

Fixes #456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryancausey @npalm @JulianCBC