fix: Replace default GitLab version and fix for docker-machine download url. #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the version-generated URL to use the GitLab fork of docker-machine as the official one is dead and buried.
GitLab has made the "generic" URLs which end in `/docker-machine` inaccessible, so instead specify a version for docker-machine and use the URL generation as that both produces URLs that work and should do the right thing in most cases. Fixes cattle-ops#457.
Version 14.8.0 had a major regression and was removed from all release distribution channels. Update to 14.8.2 as that's the latest 14.8.x version. Fixes cattle-ops#456
npalm
approved these changes
Mar 7, 2022
npalm
changed the title
|
🎉 This PR is included in version 4.41.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
npalm
pushed a commit
that referenced
this pull request
Mar 7, 2022
…ad url. (#458) * feat: Switch to GitLab's forked docker-machine version Update the version-generated URL to use the GitLab fork of docker-machine as the official one is dead and buried. * fix: Default to a version instead of an explicit URL GitLab has made the "generic" URLs which end in `/docker-machine` inaccessible, so instead specify a version for docker-machine and use the URL generation as that both produces URLs that work and should do the right thing in most cases. Fixes #457. * fix: Update runner version to 14.8.2 Version 14.8.0 had a major regression and was removed from all release distribution channels. Update to 14.8.2 as that's the latest 14.8.x version. Fixes #456
npalm
added a commit
that referenced
this pull request
May 17, 2022
…ad url. (#458) * feat: Switch to GitLab's forked docker-machine version Update the version-generated URL to use the GitLab fork of docker-machine as the official one is dead and buried. * fix: Default to a version instead of an explicit URL GitLab has made the "generic" URLs which end in `/docker-machine` inaccessible, so instead specify a version for docker-machine and use the URL generation as that both produces URLs that work and should do the right thing in most cases. Fixes #457. * fix: Update runner version to 14.8.2 Version 14.8.0 had a major regression and was removed from all release distribution channels. Update to 14.8.2 as that's the latest 14.8.x version. Fixes #456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both the default GitLab Runner and
docker-machinedownload steps are broken:/docker-machine) available Docker-machine download URL appears to be inaccessible #457Fix these by:
docker-machinedownload URL generation to explicitly use GitLab's version as the official Docker version is dead and burieddocker-machinedownload URL to specifying the GitLab fork's latest versionMigrations required
docker-machineby specifying a version and blanking the download URL, this will migrate them to the GitLab fork and probably break as the version number scheme has changed.Verification
This has been verified on my production environment, which is a slightly tweaked version of the "runner-docker" example.
Documentation
Documentation has been updated using
terraform-docs.