fix: remove the null resource #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
approved these changes
Feb 25, 2022
|
@kayman-mk looks good! can you rebase, and resolve the conflicts please? |
|
rebased |
npalm
approved these changes
Feb 27, 2022
|
🎉 This PR is included in version 4.41.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
npalm
pushed a commit
that referenced
this pull request
Mar 7, 2022
* remove the null resource * amend the docs to not forget to remove the runner manually
npalm
added a commit
that referenced
this pull request
May 17, 2022
* remove the null resource * amend the docs to not forget to remove the runner manually
npalm
pushed a commit
that referenced
this pull request
May 17, 2022
* remove the null resource * amend the docs to not forget to remove the runner manually
npalm
added a commit
that referenced
this pull request
May 19, 2022
* remove the null resource * amend the docs to not forget to remove the runner manually
npalm
added a commit
that referenced
this pull request
May 19, 2022
* remove the null resource * amend the docs to not forget to remove the runner manually
npalm
added a commit
that referenced
this pull request
May 19, 2022
* remove the null resource * amend the docs to not forget to remove the runner manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
null_resourceto remove the Gitlab runner from the Gitlab instance. Sometimes thenull_resourcewas triggered due to changes in Terraform code and your runner was removed from Gitlab causing outages of your pipelines. Unfortunately there is no Terraform resource available indicating that a module was completely removed.In case you want to get rid of this module, don't forget to remove the runner from your Gitlab instance manually.
Closes #426
Migrations required
The
null_resourceis completely removed. Please make sure to delete it from the statefile manually to avoid the runners being removed from the Gitlab instance.terraform state listwill show you everything in the state, you need to look for the "remove_runner" null_resource.terraform state rm module.<runners-module-name>.null_resource.remove_runnerVerification
No verifications done as the resource was removed.
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.