Remove runner agents if provider assumed a role #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
approved these changes
Nov 10, 2021
npalm
approved these changes
Nov 12, 2021
semantic-releaser bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
## [4.36.0](4.35.0...4.36.0) (2021-12-09) ### Features * Add /certs/client and docker.sock to volumes for docker in docker ([#396](#396)) ([3f79054](3f79054)) * Add variable for Docker registry mirror ([#400](#400)) ([e36c971](e36c971)) * Make check interval configurable for the runner ([#402](#402)) ([ed9989c](ed9989c)) ### Bug Fixes * Remove runner agents if provider assumed a role ([#401](#401)) ([9767603](9767603))
|
🎉 This PR is included in version 4.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the AWS provider assumes a role, it is not possible to use the AWS CLI to interact with the cloud resources as the CLI does not assume the role automatically. The removal of the runner agents from Gitlab fails.
This PR moves the whole script to remove the runner agent into the Terraform code and does not use the AWS CLI.
Closes #371
Migrations required
No
Verification
Still pending.
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.