Make check interval configurable for the runner #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to reduce load on gitlab API
|
One checkmark can be added to #393 by this. |
npalm
reviewed
Nov 5, 2021
variables.tf
Outdated
| variable "runners_check_interval" { | ||
| description = "defines the interval length, in seconds, between new jobs check." | ||
| type = number | ||
| default = 0 |
There was a problem hiding this comment.
Ok by me, other option could be to set the default to 3 https://docs.gitlab.com/runner/configuration/advanced-configuration.html
npalm
approved these changes
Nov 5, 2021
|
@PirminTapken please can you check the CI, looks like there is a format error. |
npalm
requested changes
Nov 10, 2021
main.tf
Outdated
| @@ -133,14 +133,15 @@ locals { | |||
| runners_root_size = var.runners_root_size | |||
| runners_iam_instance_profile_name = var.runners_iam_instance_profile_name | |||
| runners_use_private_address_only = var.runners_use_private_address | |||
| runners_use_private_address = !var.runners_use_private_address | |||
| runners_use_private_address = ! var.runners_use_private_address | |||
There was a problem hiding this comment.
Suggested change
| runners_use_private_address = ! var.runners_use_private_address | |
| runners_use_private_address = !var.runners_use_private_address |
|
@PirminTapken did you had time to check the review comment? |
|
@npalm i stepped in to fix formatting and default to 3 seconds as @PirminTapken seems quite busy |
npalm
approved these changes
Dec 3, 2021
semantic-releaser bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
## [4.36.0](4.35.0...4.36.0) (2021-12-09) ### Features * Add /certs/client and docker.sock to volumes for docker in docker ([#396](#396)) ([3f79054](3f79054)) * Add variable for Docker registry mirror ([#400](#400)) ([e36c971](e36c971)) * Make check interval configurable for the runner ([#402](#402)) ([ed9989c](ed9989c)) ### Bug Fixes * Remove runner agents if provider assumed a role ([#401](#401)) ([9767603](9767603))
|
🎉 This PR is included in version 4.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make check interval configurable for the runner in order to reduce load on gitlab API
Migrations required
NO