Support for setting Sentry DSN #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review in the weekend |
npalm
added a commit
that referenced
this pull request
Jul 31, 2021
Co-authored-by: Niek Palm <[email protected]>
semantic-releaser bot
pushed a commit
that referenced
this pull request
Aug 28, 2021
## [4.29.0](4.28.0...4.29.0) (2021-08-28) ### Features * Allow configuring docker machine egress rules, see PR [#351](#351) for upgrade instructions ([845e018](845e018)) * Parametrize runner instance launch configuration metadata options ([#348](#348)) ([a4406dc](a4406dc)) * replace launch configuration with launch template ([#337](#337)) ([b805fb6](b805fb6)) * support for settings Sentry DSN ([#352](#352)) ([2a07466](2a07466)) ### Bug Fixes * Use better ressources names ([#356](#356)) ([817e040](817e040))
|
🎉 This PR is included in version 4.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
npalm
pushed a commit
that referenced
this pull request
Oct 4, 2021
## [4.29.0](4.28.0...4.29.0) (2021-08-28) ### Features * Allow configuring docker machine egress rules, see PR [#351](#351) for upgrade instructions ([845e018](845e018)) * Parametrize runner instance launch configuration metadata options ([#348](#348)) ([a4406dc](a4406dc)) * replace launch configuration with launch template ([#337](#337)) ([b805fb6](b805fb6)) * support for settings Sentry DSN ([#352](#352)) ([2a07466](2a07466)) ### Bug Fixes * Use better ressources names ([#356](#356)) ([817e040](817e040))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitLab runners support reporting errors to Sentry which makes troubleshooting a bit easier than going through system logs.
Migrations required
NO
Verification
Tested in our live GitLab runners. Did not run the examples.
Documentation
On first apply it sets the Sentry DSN to empty string which pretty much is the default behaviour. It also creates the SSM parameter in which you should set the legacy version of your Sentry DSN and on the next startup it will use that DSN.
Btw when I ran
pre-commit runit gave me following output which I find kind of suspicious.