feat: replace launch configuration with launch template

[Michenux]

Description

AWS recommend that we should use launch templates instead of launch configurations.

With the launch template, we can now use a CMK for storage encryption. Globally, launch template allows
to configure more things than the launch configuration.

Migrations required

NO

[npalm]

thanks, will check the PR in the next days, sorry for the delay

[npalm]

Need a bit more time to check the PR. I ran a quick test with the default example. The plan is failing for this example. In this example runner_instance_spot_price is not set. In this case the agent will run on a NON spot instance. Which is the default. This will causse the following error:

Error: Invalid function argument

  on ../../main.tf line 219, in resource "aws_launch_template" "gitlab_runner_instance":
 219:     for_each = length(var.runner_instance_spot_price) == 0 ? [] : ["spot"]
 

Please can you also rebase with develop. I have fixed the CI jobs

[Michenux]

I have fixed the issues. Note that i have added an instance_refresh parameter on the runner autoscaling group to recreate the instance runner when a config is changed.

[npalm]

sorry for the late response but will check the PR

[npalm]

@Michenux great work, sorry for the late response. But I still got the following error while running the default example, see also review comment:

Error: Invalid function argument

  on ../../main.tf line 233, in resource "aws_launch_template" "gitlab_runner_instance":
 233:     for_each = var.runner_instance_spot_price != null && length(var.runner_instance_spot_price) == 0 ? [] : ["spot"]
    |----------------
    | var.runner_instance_spot_price is null

Invalid value for "value" parameter: argument must not be null.


Error: Invalid function argument

  on ../../main.tf line 271, in resource "aws_launch_template" "gitlab_runner_instance":
 271:     for_each = var.runner_instance_spot_price != null && length(var.runner_instance_spot_price) == 0 ? [] : ["spot"]
    |----------------
    | var.runner_instance_spot_price is null

Invalid value for "value" parameter: argument must not be null.

Did you fixed this issue? See only commits about formatting after my review.

[npalm]

got it working locally, need to test a bit more, sse suggestion for my changes

[npalm]

Please can you also rebase develop, change in PR #348 requires a small update in the launch template.

[Michenux]

I have rebased from develop and applied another solution for var.runner_instance_spot_price condition.

[npalm]

@Michenux thanks for all the hard work, sorry for the delay (once again). The current code is not working, once update the for_each on 2 places to for_each = var.runner_instance_spot_price == null || var.runner_instance_spot_price == "" ? [] : ["spot"] the default example works. Tested for spot and non spot.

[npalm]

Looks like you missed on configuration for the istance market option, have made a suggestion with the fix.

Did you test one ot the examples?

[semantic-releaser]

🎉 This PR is included in version 4.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀