feat: Parametrize runner instance launch configuration metadata options #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momirnikolic
changed the title
npalm
approved these changes
Jul 21, 2021
Co-authored-by: Niek Palm <[email protected]>
Co-authored-by: Niek Palm <[email protected]>
|
@npalm Thank you on a prompt review. |
npalm
added a commit
that referenced
this pull request
Jul 22, 2021
…ns (#348) * Parametrize runner instance launch configuration metadata options * Parametrize runner instance launch configuration metadata options * Update variables.tf Co-authored-by: Niek Palm <[email protected]> * Update variables.tf Co-authored-by: Niek Palm <[email protected]> Co-authored-by: Momir Nikolic <[email protected]> Co-authored-by: Niek Palm <[email protected]>
semantic-releaser bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
## [4.27.0](4.26.0...4.27.0) (2021-07-22) ### Features * Parametrize runner instance launch configuration metadata options ([#348](#348)) ([92204ee](92204ee))
radimsuckr
pushed a commit
to radimsuckr/terraform-aws-gitlab-runner
that referenced
this pull request
Jul 29, 2021
## [4.27.0](cattle-ops/terraform-aws-gitlab-runner@4.26.0...4.27.0) (2021-07-22) ### Features * Parametrize runner instance launch configuration metadata options ([cattle-ops#348](cattle-ops#348)) ([92204ee](cattle-ops@92204ee))
semantic-releaser bot
pushed a commit
that referenced
this pull request
Aug 28, 2021
## [4.29.0](4.28.0...4.29.0) (2021-08-28) ### Features * Allow configuring docker machine egress rules, see PR [#351](#351) for upgrade instructions ([845e018](845e018)) * Parametrize runner instance launch configuration metadata options ([#348](#348)) ([a4406dc](a4406dc)) * replace launch configuration with launch template ([#337](#337)) ([b805fb6](b805fb6)) * support for settings Sentry DSN ([#352](#352)) ([2a07466](2a07466)) ### Bug Fixes * Use better ressources names ([#356](#356)) ([817e040](817e040))
|
🎉 This PR is included in version 4.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
npalm
pushed a commit
that referenced
this pull request
Oct 4, 2021
## [4.29.0](4.28.0...4.29.0) (2021-08-28) ### Features * Allow configuring docker machine egress rules, see PR [#351](#351) for upgrade instructions ([845e018](845e018)) * Parametrize runner instance launch configuration metadata options ([#348](#348)) ([a4406dc](a4406dc)) * replace launch configuration with launch template ([#337](#337)) ([b805fb6](b805fb6)) * support for settings Sentry DSN ([#352](#352)) ([2a07466](2a07466)) ### Bug Fixes * Use better ressources names ([#356](#356)) ([817e040](817e040))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parametrize usage of Gitlab runner agent instance AWS metadata service in launch configuration. This enables control of instance AWS IMDSv1 and IMDSv2 options and enables mitigation of AWS Security Hub issue related to IMDSv1 being enabled (EC2 instances should use Instance Metadata Service Version 2 (IMDSv2))
Migrations required
NO
Verification
Launch configuration AWS metadata service options change based on input variables given to the module.
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.