Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Deprecated Resource #332

Closed
Nightbr opened this issue Jun 28, 2021 · 0 comments
Closed

Warning Deprecated Resource #332

Nightbr opened this issue Jun 28, 2021 · 0 comments

Comments

@Nightbr
Copy link

Nightbr commented Jun 28, 2021

Hey,

seems there is a warning on Deprecated Resource with Terraform 1.0.1

╷
│ Warning: Deprecated Resource
│ 
│   with module.gitlab-runner.data.null_data_source.tags,
│   on .terraform/modules/gitlab-runner/tags.tf line 32, in data "null_data_source" "tags":
│   32: data "null_data_source" "tags" {
│ 
│ The null_data_source was historically used to construct intermediate values to re-use elsewhere in configuration, the same can now be achieved using locals
│ 
│ (and 9 more similar warnings elsewhere)

Instead of using data "null_data_source" "tags" we should use locals {}.

Add to that I know a really good module to manage tags in Terraform: https://github.com/cloudposse/terraform-null-label

kayman-mk added a commit to kayman-mk/terraform-aws-gitlab-runner that referenced this issue Jul 3, 2021
npalm pushed a commit that referenced this issue Jul 8, 2021
* remove the null_data_source (#332)

* Allow newer Terraform versions

Co-authored-by: kayma <[email protected]>
semantic-releaser bot pushed a commit that referenced this issue Jul 8, 2021
## [4.26.0](4.25.0...4.26.0) (2021-07-08)

### Features

* Add `role_tags` to support tag based authorization ([#333](#333)) ([#335](#335)) ([c81f221](c81f221))
* Make disable_cache configurable ([#324](#324)) ([d726cf4](d726cf4))
* replace default volume type gp2 by gp3  ([#338](#338)) ([1bfaf2b](1bfaf2b)), closes [#318](#318)
* upgrade default runner version to 14.0.1 ([#341](#341)) ([18b4103](18b4103))

### Bug Fixes

* add tags for instance profile ([#331](#331)) ([b42712f](b42712f))
* Remove deprecarted null_data_source ([#332](#332)) ([#334](#334)) ([b3ab3f6](b3ab3f6))
* replace deprecated null_data_source with locals ([#336](#336)) ([6a240c9](6a240c9))
* support terraform 1.x ([800c264](800c264)), closes [#330](#330)
@npalm npalm closed this as completed Jul 8, 2021
radimsuckr pushed a commit to radimsuckr/terraform-aws-gitlab-runner that referenced this issue Jul 29, 2021
## [4.26.0](cattle-ops/terraform-aws-gitlab-runner@4.25.0...4.26.0) (2021-07-08)

### Features

* Add `role_tags` to support tag based authorization ([cattle-ops#333](cattle-ops#333)) ([cattle-ops#335](cattle-ops#335)) ([c81f221](cattle-ops@c81f221))
* Make disable_cache configurable ([cattle-ops#324](cattle-ops#324)) ([d726cf4](cattle-ops@d726cf4))
* replace default volume type gp2 by gp3  ([cattle-ops#338](cattle-ops#338)) ([1bfaf2b](cattle-ops@1bfaf2b)), closes [cattle-ops#318](cattle-ops#318)
* upgrade default runner version to 14.0.1 ([cattle-ops#341](cattle-ops#341)) ([18b4103](cattle-ops@18b4103))

### Bug Fixes

* add tags for instance profile ([cattle-ops#331](cattle-ops#331)) ([b42712f](cattle-ops@b42712f))
* Remove deprecarted null_data_source ([cattle-ops#332](cattle-ops#332)) ([cattle-ops#334](cattle-ops#334)) ([b3ab3f6](cattle-ops@b3ab3f6))
* replace deprecated null_data_source with locals ([cattle-ops#336](cattle-ops#336)) ([6a240c9](cattle-ops@6a240c9))
* support terraform 1.x ([800c264](cattle-ops@800c264)), closes [cattle-ops#330](cattle-ops#330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants