Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make disable_cache configurable #324

Merged
merged 3 commits into from May 21, 2021
Merged

Make disable_cache configurable #324

merged 3 commits into from May 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 20, 2021

Description

Runners are running out of space rapidly because they do not discard local docker images

Migrations required

NO

Verification

Tested with my own TF setup (runners_default)

Documentation

Updated!


I've left the default to false because this is how this project was currently set-up, however I believe disable_cache should be set to true for most use-cases when using auto-scaling, as described in Gitlab's documentation

@npalm npalm self-requested a review May 21, 2021 20:28
Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierlucg-xs thanks for your contribution. looks good.

@npalm npalm merged commit d726cf4 into cattle-ops:develop May 21, 2021
semantic-releaser bot pushed a commit that referenced this pull request Jul 8, 2021
## [4.26.0](4.25.0...4.26.0) (2021-07-08)

### Features

* Add `role_tags` to support tag based authorization ([#333](#333)) ([#335](#335)) ([c81f221](c81f221))
* Make disable_cache configurable ([#324](#324)) ([d726cf4](d726cf4))
* replace default volume type gp2 by gp3  ([#338](#338)) ([1bfaf2b](1bfaf2b)), closes [#318](#318)
* upgrade default runner version to 14.0.1 ([#341](#341)) ([18b4103](18b4103))

### Bug Fixes

* add tags for instance profile ([#331](#331)) ([b42712f](b42712f))
* Remove deprecarted null_data_source ([#332](#332)) ([#334](#334)) ([b3ab3f6](b3ab3f6))
* replace deprecated null_data_source with locals ([#336](#336)) ([6a240c9](6a240c9))
* support terraform 1.x ([800c264](800c264)), closes [#330](#330)
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 4.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

radimsuckr pushed a commit to radimsuckr/terraform-aws-gitlab-runner that referenced this pull request Jul 29, 2021
## [4.26.0](cattle-ops/terraform-aws-gitlab-runner@4.25.0...4.26.0) (2021-07-08)

### Features

* Add `role_tags` to support tag based authorization ([cattle-ops#333](cattle-ops#333)) ([cattle-ops#335](cattle-ops#335)) ([c81f221](cattle-ops@c81f221))
* Make disable_cache configurable ([cattle-ops#324](cattle-ops#324)) ([d726cf4](cattle-ops@d726cf4))
* replace default volume type gp2 by gp3  ([cattle-ops#338](cattle-ops#338)) ([1bfaf2b](cattle-ops@1bfaf2b)), closes [cattle-ops#318](cattle-ops#318)
* upgrade default runner version to 14.0.1 ([cattle-ops#341](cattle-ops#341)) ([18b4103](cattle-ops@18b4103))

### Bug Fixes

* add tags for instance profile ([cattle-ops#331](cattle-ops#331)) ([b42712f](cattle-ops@b42712f))
* Remove deprecarted null_data_source ([cattle-ops#332](cattle-ops#332)) ([cattle-ops#334](cattle-ops#334)) ([b3ab3f6](cattle-ops@b3ab3f6))
* replace deprecated null_data_source with locals ([cattle-ops#336](cattle-ops#336)) ([6a240c9](cattle-ops@6a240c9))
* support terraform 1.x ([800c264](cattle-ops@800c264)), closes [cattle-ops#330](cattle-ops#330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant